Skip to content

Conversation

@jyasskin
Copy link
Contributor

@jyasskin jyasskin commented Jul 2, 2025

Also adjust editorconfig to indent workflows correctly.

This is blocked on w3c/spec-prod#207.

jyasskin added a commit to jyasskin/explainer-explainer that referenced this pull request Jul 2, 2025
@jyasskin jyasskin force-pushed the validate-pubrules branch from b559fc9 to 954652b Compare July 2, 2025 18:21
@sidvishnoi
Copy link
Collaborator

@jyasskin can you try again? w3c/spec-prod#207 has some fixes that I found working fine locally.

Also adjust editorconfig to indent workflows correctly.
@sidvishnoi
Copy link
Collaborator

I saw something else broke with setup-node part. Will address.

@jyasskin
Copy link
Contributor Author

@sidvishnoi Something's wrong now with how the action installs itself:

Error: Dependencies lock file is not found in /home/runner/work/explainer-explainer/explainer-explainer. Supported file patterns: pnpm-lock.yaml

@sidvishnoi
Copy link
Collaborator

sidvishnoi commented Sep 20, 2025

@jyasskin Requesting a last attempt from you, before I setup and test myself in a fork. 🙏
(The invite for this that you sent few months ago has expired)

nvm. I'm testing on my fork now.

@sidvishnoi
Copy link
Collaborator

@jyasskin it works now. I'll release new version of the spec-prod action tomorrow or on Monday.

@jyasskin jyasskin marked this pull request as ready for review September 22, 2025 17:02
@jyasskin
Copy link
Contributor Author

Thanks @sidvishnoi!

@jyasskin jyasskin merged commit 3fd038c into w3ctag:main Sep 22, 2025
1 check passed
@jyasskin jyasskin deleted the validate-pubrules branch September 22, 2025 17:04
github-actions bot added a commit that referenced this pull request Sep 22, 2025
SHA: 3fd038c
Reason: push, by jyasskin

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
jyasskin added a commit that referenced this pull request Oct 1, 2025
This reverts most of commit 3fd038c
but leaves the incidental .editorconfig change.

The fix in spec-prod was effectively reverted due to
w3c/spec-prod#213.
github-actions bot added a commit that referenced this pull request Oct 1, 2025
SHA: d5e6416
Reason: push, by jyasskin

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants